Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove rqt_graph script. #66

Open
wants to merge 1 commit into
base: rolling
Choose a base branch
from
Open

Conversation

clalancette
Copy link

Instead, only install the console script, which means it will
work on both Unix and Windows.

Signed-off-by: Chris Lalancette clalancette@openrobotics.org

If we go with this PR, there are a few consequences:

  1. Running rqt_graph on Linux will no longer work. This is a change from earlier distributions, and what we had previously discussed, but it does bring rqt_graph in line with almost all of the other rqt plugins.
  2. We'll have to update the documentation, since at least https://docs.ros.org/en/rolling/Tutorials/Launch-Files/Creating-Launch-Files.html and https://docs.ros.org/en/rolling/Tutorials/Topics/Understanding-ROS2-Topics.html use the 'bare' style.
  3. We should update the release notes to explicitly call this change out.

Instead, only install the console script, which means it will
work on both Unix and Windows.

Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
@clalancette
Copy link
Author

@ros-pull-request-builder retest this please

2 similar comments
@clalancette
Copy link
Author

@ros-pull-request-builder retest this please

@clalancette
Copy link
Author

@ros-pull-request-builder retest this please

@audrow audrow changed the base branch from galactic-devel to rolling June 28, 2022 14:16
@ahcorde
Copy link

ahcorde commented Aug 20, 2024

is this PR still relevant @clalancette ?

@ahcorde ahcorde added the ros2 label Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants