-
Notifications
You must be signed in to change notification settings - Fork 463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compatibility with Ogre 13 #1791
Compatibility with Ogre 13 #1791
Conversation
08af2d3
to
121f3a3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay reviewing this. Your changes look good.
It would be great to include Ogre 1.13 in the GHA tests here:
rviz/.github/workflows/ci.yaml
Line 17 in 93ac44b
ogre: ["1.9", "1.12"] |
To this end, we would need to setup a .deb repository to install libogre-13.x-dev
from, which is done here:
rviz/.github/workflows/ci.yaml
Line 27 in 93ac44b
AFTER_INSTALL_TARGET_DEPENDENCIES: apt install -qq -y libogre-${{ matrix.ogre }}-dev |
However, your PPA doesn't provide a -dev package and it is targeted at Jammy only.
Could you please augment?
I'll check what it takes to build it on Focal, sure. What do you mean by "doesn't provide a -dev package"? https://launchpad.net/~s-schmeisser/+archive/ubuntu/ogre-13/+packages has libogre-13.6-dev |
Note that I failed in getting gazebo to work with Ogre 13 as they use insane amounts of private API which is no longer accessible (or partially removed) in Ogre 13. |
You are right. I just have seen the top-level entries.
I just want to ensure that future changes won't break Ogre 13 compatibility again... |
4f1f55e
to
acd7cd9
Compare
acd7cd9
to
1ecdd40
Compare
Merged in 9911c32. |
This fixes compatibility with Ogre 13.6.4, the most recent release. It requires two special cmake flags when building Ogre: