Fix vanishing "Global Options" property when adding a RobotModelDisplay #1808
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With Qt 5.15, the
Global Options
property was vanishing, when aRobotModelDisplay
was added with links having no geometry. In this case, theAlpha
property of the corresponding link is hidden.However, hiding a property:
rviz/src/rviz/properties/property.cpp
Line 398 in 4129ee4
during the process of reparenting:
rviz/src/rviz/properties/property.cpp
Line 373 in 4129ee4
caused setRowHidden to be called with an invalid
parentIndex
:rviz/src/rviz/properties/property_tree_widget.cpp
Line 125 in 4129ee4
which then caused hiding of the corresponding top-level property.