Qt6 compat #1813
Merged
Qt6 compat #1813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhaschke
reviewed
Jan 28, 2024
Simplify code by using foreach instead of while loop.
|
Thanks for your patience Robert and sorry for not being fully concentrated! |
|
??? The evolution of this PR was all fine for me. Nothing to be sorry about! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes some errors (and warnings) when compiling with Qt6. Most was deprecated with 5.0 already.
The last commit is meant purely informational and should not be merged.
Unfortunately there is no PyQt6 available on Ubuntu 22.04 so I disabled the python bindings. Also choosing Qt6 over Qt5 does not seem to work somehow.