Stop showing all of the performance plots

[cottsay]

There are now over 1000 PNG plots being generated during the nightly performance jobs. This makes the build page WAY too big and take really long to load. Even after it does, finding the plot you're interested in is almost impossible given that there are no text titles to search for (the titles are embedded in the images).

I think we should just disable the image gallery plugin. We can keep the plots as archived file artifacts so that they can be linked to from the build-over-build plots.

Results in the following diff:

Updating job 'Dci__nightly-performance_ubuntu_bionic_amd64' (dry run)
    <<<
    --- remote config
    +++ new config
    @@ -503 +503 @@
    -      <artifacts>ros2-dashing-linux-bionic-amd64-ci.tar.bz2,ws/test_results/buildfarm_perf_tests/performance_test_results_*.png,ws/test_results/buildfarm_perf_tests/overhead_test_results_*.png,ws/test_results/buildfarm_perf_tests/overhead_node_test_results_*.png,ws/test_results/buildfarm_perf_tests/performance_test_two_process_results_*.png</artifacts>
    +      <artifacts>ros2-dashing-linux-bionic-amd64-ci.tar.bz2,ws/test_results/buildfarm_perf_tests/overhead_node_test_results_*.csv,ws/test_results/buildfarm_perf_tests/overhead_node_test_results_*.png,ws/test_results/buildfarm_perf_tests/overhead_test_results_*.csv,ws/test_results/buildfarm_perf_tests/overhead_test_results_*.png,ws/test_results/buildfarm_perf_tests/performance_test_results_*.csv,ws/test_results/buildfarm_perf_tests/performance_test_results_*.png,ws/test_results/buildfarm_perf_tests/performance_test_two_process_results_*.csv,ws/test_results/buildfarm_perf_tests/performance_test_two_process_results_*.png</artifacts>
    @@ -510,10 +509,0 @@
    -    <org.jenkinsci.plugins.imagegallery.ImageGalleryRecorder plugin="image-gallery@1.4">
    -      <imageGalleries>
    -        <org.jenkinsci.plugins.imagegallery.imagegallery.ArchivedImagesGallery>
    -          <title>Performance Test Results</title>
    -          <imageWidthText />
    -          <markBuildAsUnstableIfNoArchivesFound>false</markBuildAsUnstableIfNoArchivesFound>
    -          <includes>ws/test_results/buildfarm_perf_tests/performance_test_results_*.png,ws/test_results/buildfarm_perf_tests/overhead_test_results_*.png,ws/test_results/buildfarm_perf_tests/overhead_node_test_results_*.png,ws/test_results/buildfarm_perf_tests/performance_test_two_process_results_*.png</includes>
    -        </org.jenkinsci.plugins.imagegallery.imagegallery.ArchivedImagesGallery>
    -      </imageGalleries>
    -    </org.jenkinsci.plugins.imagegallery.ImageGalleryRecorder>
    >>>
Updating job 'Eci__nightly-performance_ubuntu_bionic_amd64' (dry run)
    <<<
    --- remote config
    +++ new config
    @@ -503 +503 @@
    -      <artifacts>ros2-eloquent-linux-bionic-amd64-ci.tar.bz2,ws/test_results/buildfarm_perf_tests/performance_test_results_*.png,ws/test_results/buildfarm_perf_tests/overhead_test_results_*.png,ws/test_results/buildfarm_perf_tests/overhead_node_test_results_*.png,ws/test_results/buildfarm_perf_tests/performance_test_two_process_results_*.png</artifacts>
    +      <artifacts>ros2-eloquent-linux-bionic-amd64-ci.tar.bz2,ws/test_results/buildfarm_perf_tests/overhead_node_test_results_*.csv,ws/test_results/buildfarm_perf_tests/overhead_node_test_results_*.png,ws/test_results/buildfarm_perf_tests/overhead_test_results_*.csv,ws/test_results/buildfarm_perf_tests/overhead_test_results_*.png,ws/test_results/buildfarm_perf_tests/performance_test_results_*.csv,ws/test_results/buildfarm_perf_tests/performance_test_results_*.png,ws/test_results/buildfarm_perf_tests/performance_test_two_process_results_*.csv,ws/test_results/buildfarm_perf_tests/performance_test_two_process_results_*.png</artifacts>
    @@ -510,10 +509,0 @@
    -    <org.jenkinsci.plugins.imagegallery.ImageGalleryRecorder plugin="image-gallery@1.4">
    -      <imageGalleries>
    -        <org.jenkinsci.plugins.imagegallery.imagegallery.ArchivedImagesGallery>
    -          <title>Performance Test Results</title>
    -          <imageWidthText />
    -          <markBuildAsUnstableIfNoArchivesFound>false</markBuildAsUnstableIfNoArchivesFound>
    -          <includes>ws/test_results/buildfarm_perf_tests/performance_test_results_*.png,ws/test_results/buildfarm_perf_tests/overhead_test_results_*.png,ws/test_results/buildfarm_perf_tests/overhead_node_test_results_*.png,ws/test_results/buildfarm_perf_tests/performance_test_two_process_results_*.png</includes>
    -        </org.jenkinsci.plugins.imagegallery.imagegallery.ArchivedImagesGallery>
    -      </imageGalleries>
    -    </org.jenkinsci.plugins.imagegallery.ImageGalleryRecorder>
    >>>
Updating job 'Fci__nightly-performance_ubuntu_focal_amd64' (dry run)
    <<<
    --- remote config
    +++ new config
    @@ -503 +503 @@
    -      <artifacts>ros2-foxy-linux-focal-amd64-ci.tar.bz2,ws/test_results/buildfarm_perf_tests/performance_test_results_*.csv,ws/test_results/buildfarm_perf_tests/overhead_test_results_*.csv,ws/test_results/buildfarm_perf_tests/overhead_node_test_results_*.csv,ws/test_results/buildfarm_perf_tests/performance_test_two_process_results_*.csv,ws/test_results/buildfarm_perf_tests/performance_test_results_*.png,ws/test_results/buildfarm_perf_tests/overhead_test_results_*.png,ws/test_results/buildfarm_perf_tests/overhead_node_test_results_*.png,ws/test_results/buildfarm_perf_tests/performance_test_two_process_results_*.png</artifacts>
    +      <artifacts>ros2-foxy-linux-focal-amd64-ci.tar.bz2,ws/test_results/buildfarm_perf_tests/overhead_node_test_results_*.csv,ws/test_results/buildfarm_perf_tests/overhead_node_test_results_*.png,ws/test_results/buildfarm_perf_tests/overhead_test_results_*.csv,ws/test_results/buildfarm_perf_tests/overhead_test_results_*.png,ws/test_results/buildfarm_perf_tests/performance_test_results_*.csv,ws/test_results/buildfarm_perf_tests/performance_test_results_*.png,ws/test_results/buildfarm_perf_tests/performance_test_two_process_results_*.csv,ws/test_results/buildfarm_perf_tests/performance_test_two_process_results_*.png</artifacts>
    @@ -510,10 +509,0 @@
    -    <org.jenkinsci.plugins.imagegallery.ImageGalleryRecorder plugin="image-gallery@1.4">
    -      <imageGalleries>
    -        <org.jenkinsci.plugins.imagegallery.imagegallery.ArchivedImagesGallery>
    -          <title>Performance Test Results</title>
    -          <imageWidthText />
    -          <markBuildAsUnstableIfNoArchivesFound>false</markBuildAsUnstableIfNoArchivesFound>
    -          <includes>ws/test_results/buildfarm_perf_tests/performance_test_results_*.png,ws/test_results/buildfarm_perf_tests/overhead_test_results_*.png,ws/test_results/buildfarm_perf_tests/overhead_node_test_results_*.png,ws/test_results/buildfarm_perf_tests/performance_test_two_process_results_*.png</includes>
    -        </org.jenkinsci.plugins.imagegallery.imagegallery.ArchivedImagesGallery>
    -      </imageGalleries>
    -    </org.jenkinsci.plugins.imagegallery.ImageGalleryRecorder>
    >>>

[dirk-thomas]

I think we should just disable the image gallery plugin.

Would it make sense to at least show some selected plots?

[cottsay]

Would it make sense to at least show some selected plots?

@ahcorde, do you have any thoughts about this? Is there some subset of of the current results you believe might be interesting to display on the build page?

The patterns appear to use "ant syntax", but that doesn't seem to buy us much here. I don't see a way to do "exclude" filtering on the matches.

[ahcorde]

These plots will be always available clicking in the plots that generate the Jenkins plot plugin. All these plots ae unsorted, it's difficult to find what you are looking for or understand what is going on. +1 to remove it. Maybe you can show only "latency" but I don't have a strong opinion on that.

[dirk-thomas]

@cottsay What is the status on this?