Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update freetype2 #1302

Open
wants to merge 1 commit into
base: rolling
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion rviz_ogre_vendor/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ if(WIN32)

ament_vendor(freetype_vendor
VCS_URL https://git.savannah.gnu.org/git/freetype/freetype2.git
VCS_VERSION VER-2-13-2
VCS_VERSION VER-2-13-3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This updates us beyond the version that is packaged in Ubuntu 24.04, which is freetype 2.13.2. Can you explain why you want to do this update?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am trying to make a highly performant and reliable version of rviz.
I currently use mesh >2 Gb in real time simulation environments.
In addition to modifying ogre (I submitted an intermediate patch that does not impact the ros #1305 ecosystem), I also modified the freetype version for the following reasons:

  • Rare double-free crashes in the cache subsystem have been fixed.
  • Excessive stack allocation in the autohinter has been fixed.
  • The B/W rendering speed has increased and even doubled for very complex glyphs.

CMAKE_ARGS
-DFT_DISABLE_ZLIB:BOOL=ON
-DFT_DISABLE_BZIP2:BOOL=ON
Expand Down