Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate functions #53

Merged
merged 29 commits into from
Aug 23, 2023
Merged

Validate functions #53

merged 29 commits into from
Aug 23, 2023

Conversation

samestep
Copy link
Contributor

@samestep samestep commented Jul 6, 2023 •
edited
Loading

Resolves #28.

@samestep samestep mentioned this pull request Jul 6, 2023
Merged
@samestep samestep mentioned this pull request Aug 4, 2023
Merged
@samestep samestep marked this pull request as ready for review August 4, 2023 19:53
@samestep samestep marked this pull request as draft August 7, 2023 13:49
@samestep samestep marked this pull request as ready for review August 7, 2023 15:28
ravenrothkopf
ravenrothkopf approved these changes Aug 23, 2023
View reviewed changes
Copy link
Contributor

@ravenrothkopf ravenrothkopf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow this took a while to get through, but LGTM!! Thank you so much for doing this and sorry it took me so long to review lol

@samestep
Copy link
Contributor Author

Thanks for reviewing @ravenrothkopf! Sorry this ended up being so much code to review 😅

@samestep samestep merged commit aa34e18 into main Aug 23, 2023
2 checks passed
@samestep samestep deleted the validate branch August 23, 2023 16:37
@samestep samestep mentioned this pull request Aug 23, 2023
Open
@samestep samestep mentioned this pull request Sep 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ravenrothkopf ravenrothkopf ravenrothkopf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Validate the IR
2 participants
@samestep @ravenrothkopf