Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added possibility to run calc_unbalanced for rdm movies #331

Merged
merged 3 commits into from
Oct 31, 2023

Conversation

HeikoSchuett
Copy link
Contributor

It came up in support mail recently, that there is no way to run the unbalanced calculations to creat RDM movies. This pull request adds a flag to calc_rdm_movie to allow this and then just runs calc_rdm_unbalanced instead of calc_rdm.

This requiered a little bit of restructuring of helper functions to prevent circular imports between calc_rdm and calc_rdm unbalanced.

Copy link
Contributor

@JasperVanDenBosch JasperVanDenBosch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JasperVanDenBosch JasperVanDenBosch merged commit 330af9c into main Oct 31, 2023
20 checks passed
@JasperVanDenBosch JasperVanDenBosch deleted the unbalanced_movie branch October 31, 2023 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants