Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switched to nanmeans for t-tests #335

Merged
merged 2 commits into from
Aug 8, 2023
Merged

switched to nanmeans for t-tests #335

merged 2 commits into from
Aug 8, 2023

Conversation

HeikoSchuett
Copy link
Contributor

For small datasets individual bootstrap evaluations can become nan
In these cases we still want to get p-values from the tests, i.e. use nanmean instead of mean.

@HeikoSchuett
Copy link
Contributor Author

@ilogue could you have a look what breaks these tests? I cannot reproduce the error locally and did not change the odd even split code at all

@JasperVanDenBosch
Copy link
Contributor

@ilogue could you have a look what breaks these tests? I cannot reproduce the error locally and did not change the odd even split code at all

Yeah it's definitely not related to these changes. I'm investigating in #336. I suspect it's just that one of our dependencies has changed its behaviour.

@HeikoSchuett HeikoSchuett merged commit 01e767c into main Aug 8, 2023
3 of 4 checks passed
@HeikoSchuett HeikoSchuett deleted the nan_mean branch September 20, 2023 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Keep getting NAN's when using 'rsatoolbox.inference.eval_bootstrap_pattern'
2 participants