Merge pull request #8 from rsksmart/bug/04_00_02_fedchange

sonarcloud bug complain fix
rsksmart · Sep 14, 2023 · b5a285a · b5a285a
2 parents ae3be4e + 89cda18
commit b5a285a
Showing 1 changed file with 7 additions and 7 deletions.
diff --git a/tests/04_00_02-fedchange.js b/tests/04_00_02-fedchange.js
@@ -279,16 +279,16 @@ describe('RSK Federation change', function() {
       }
 
       await checkFederationAddedNewKeys();
-      var addResult = await rskClientOldFed.rsk.bridge.methods.addFederatorPublicKeyMultikey('0xaabb', '0xccdd', '0xeeff').call({ from: getRandomFedChangeAddress() });
-      expect(Number(addResult)).to.equal(-10); // not a public key
-      
-      await rskClientOldFed.rsk.bridge.methods.addFederatorPublicKeyMultikey(
+      const addKeysResult = await rskClientOldFed.rsk.bridge.methods.addFederatorPublicKeyMultikey('0xaabb', '0xccdd', '0xeeff').call({ from: getRandomFedChangeAddress() });
+      expect(Number(addKeysResult)).to.equal(-10); // not a public key
+
+      const addPublicKeysResult = await rskClientOldFed.rsk.bridge.methods.addFederatorPublicKeyMultikey(
         newFederationPublicKeys[0][KEY_TYPE_BTC],
         newFederationPublicKeys[0][KEY_TYPE_RSK],
         newFederationPublicKeys[0][KEY_TYPE_MST]
-      ).call({ from: getRandomFedChangeAddress() }), (addResult => {
-          expect(Number(addResult)).to.equal(-2); // already in there
-      });
+      ).call({ from: getRandomFedChangeAddress() });
+
+      expect(Number(addPublicKeysResult)).to.equal(-2);
 
       var sz = await rskClientOldFed.rsk.bridge.methods.getPendingFederationSize().call();
       expect(Number(sz)).to.equal(newFederationPublicKeys.length); // success