Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add-vault-token-bridge #347

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add-vault-token-bridge #347

wants to merge 1 commit into from

Conversation

joaoiovlabs
Copy link
Contributor

Title of pull request

The pull request should be described here

Description

  • Describe here your pull request modifications
  • It could be more than one thing

How to Test

  • Run both ganache-cli
  • Enter into the bridge directory and run all the tests

Case 1

  1. Go to bridge directory
$~ cd bridge
  1. Run all the tests
$~ npm run test

Expected Result

  • It should pass the test
    image
  1. Run the first ganache-cli
$~ npm run ganache
  1. Open another shell and run the ganache mirror
$~ npm run ganache-mirror
  1. Go to the federator directory
$~ cd ../federator
  1. Run the integration test
$~ npm run integrationTest

Expected Result

  • It should pass the test
    image
  1. Run the integration test
$~ npm run integrationTest

Expected Result

  • It should pass the test
    image

Case N...

Checklist

Bridge Directory cd bridge

  • [] Lint is clean npm run lint
  • [] Test is passing npm run test
  • [] Contracts are compiling npm run compile

Federator Directory cd federator

  • [] Lint is clean npm run lint
  • [] Test is passing npm run test
  • [] Typescript is compiling npm run build

@joaoiovlabs joaoiovlabs requested a review from aguschirico July 12, 2022 20:00
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@lgtm-com
Copy link

lgtm-com bot commented Jul 12, 2022

This pull request introduces 1 alert when merging 656ffef into 297ed54 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

aguschirico
aguschirico reviewed Jul 13, 2022
View reviewed changes
Copy link
Contributor

@aguschirico aguschirico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent. Although we won't merge this, I think with this we can consider the full solution ready to be implemented, right?
Have you tested this version by making your local federator to be actively voting transactions?

@snyk-bot snyk-bot mentioned this pull request Oct 12, 2022
Open
@Luisfc68 Luisfc68 force-pushed the add-vault-token-bridge branch from 656ffef to 73aba4c Compare July 7, 2023 12:36
@Luisfc68 Luisfc68 force-pushed the add-vault-token-bridge branch from 73aba4c to e298bd2 Compare July 31, 2023 12:16
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug C 1 Bug
Vulnerability A 0 Vulnerabilities
Security Hotspot E 1 Security Hotspot
Code Smell A 1 Code Smell

No Coverage information No Coverage information
5.4% 5.4% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
E Security Rating on New Code (required ≥ A)
2 New Blocker Issues (required ≤ 0)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aguschirico aguschirico aguschirico left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joaoiovlabs @aguschirico