Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I have added support to your plugin for controlling "keyframe" animations. I'd like to get your feedback before continuing to go any further.
Right now this supports the following:
Applying a "keyframe" animation by name to an element.
Pause/play/reset
Callbacks
I supported your "alternate" style of passing callbacks in as well, as a coffee-script user it makes things much easier to have it in the hash like that. I also tried to follow your code conventions as much as possible. The one exception is that I did not implement a "splat" style method signature. This is because there are a large number of arguments to the keyframe animation call, and it seems unreasonable for the user to have to think about the order or set them in order if they just want to customize a few. I am open to implementing the "splat" style though, if you think it should be there.
I have yet to do two things:
Note this is sortof related to your issue #3, which mentioned keyframe support.