-
Notifications
You must be signed in to change notification settings - Fork 861
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update default useTransitionEnd to true #184
base: master
Are you sure you want to change the base?
Conversation
I've been using this plugin in many projects and in almost every project the animations are much smoother when useTransitionEnd is on true. Especially when a jQuery .stop() is used.
It's not working for me: tested on Opera 12.16, Chrome 31, Firefox 26. |
The reason behind the change is because animations weren't finishing properly (when putting a .stop() in front if the transition). When usetransitionend was set to true they did work perfectly. About the callback; this one also ain't working here. I had to create a custom transitionEnd function. |
The reason it isn't default is that there's almost no guarantee that it will consistently be used. For instance, Any proposals on how to handle this? |
Also, the next version (0.9.10) will fix transitionend not firing in certain browsers. |
rstacruz, |
Hm, I think I'd like to have |
Yes I have tested it already, but you have also said that: "Also, the next version (0.9.10) will fix transitionend not firing in certain browsers." |
Whatever uses |
I've tested all latest Firefox and Chrome browsers and in all everythings works fine when using transitionEnd. Can you confirm that I understood corectly problems may occur when for eg, .css({padding: 0}).transition({padding: 0}) but in other cases it should work fine? |
Yes: so far that's the only case that persists in my testing. |
I have found that in firefox and chrome sometimes when you transitioning Y, Maybe plugin should check is transitioned property values are the same as
|
Good call — definitely something to investigate for 1.0.0. |
Would be nice if the doc was updated to explain the use of the Side note, thanks for the great lib @rstacruz! Hope support is continued and strong moving forward. |
It's worth noting that current versions of Chrome (confirmed for 42-45 on Windows ) have various issues firing You can see it here. |
I've been using this plugin in many projects and in almost every project the animations are much smoother when useTransitionEnd is on true. Especially when a jQuery .stop() is used.