Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update docs for Package Manager Postgres.UsageDataPassword bug #561

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+24 −4
Open

Update docs for Package Manager Postgres.UsageDataPassword bug #561

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f1b4572
Update docs for Package Manager Postgres.UsageDataPassword bug
glin Sep 26, 2024
40586b8
Update helm-docs and README.md
actions-user Sep 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/rstudio-pm/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name: rstudio-pm
description: Official Helm chart for Posit Package Manager
version: 0.5.34
version: 0.5.35
apiVersion: v2
appVersion: 2024.08.2
icon: https://rstudio.com/wp-content/uploads/2018/10/RStudio-Logo-Flat.png
Expand Down
4 changes: 4 additions & 0 deletions charts/rstudio-pm/NEWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# Changelog

## 0.5.35

- Update PostgreSQL configuration documentation to temporarily work around bug with `Postgres.UsageDataPassword` in Package Manager 2024.08.2.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is this update?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh what, wow, the automated helm-docs rebuild overwrote my readme change from 0995998

I might have to recreate this PR 🤔. I messed up originally by not bumping the chart version when making the readme change, and that might have messed things up?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I totally missed that there was a readme template file. Should look right now.


## 0.5.34

- Add `pod.securityContext.fsGroup = 999` value to set file permissions correctly when using shared storage.
Expand Down
14 changes: 11 additions & 3 deletions charts/rstudio-pm/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Posit Package Manager

![Version: 0.5.34](https://img.shields.io/badge/Version-0.5.34-informational?style=flat-square) ![AppVersion: 2024.08.2](https://img.shields.io/badge/AppVersion-2024.08.2-informational?style=flat-square)
![Version: 0.5.35](https://img.shields.io/badge/Version-0.5.35-informational?style=flat-square) ![AppVersion: 2024.08.2](https://img.shields.io/badge/AppVersion-2024.08.2-informational?style=flat-square)

#### _Official Helm chart for Posit Package Manager_

Expand All @@ -24,11 +24,11 @@ To ensure a stable production deployment:

## Installing the chart

To install the chart with the release name `my-release` at version 0.5.34:
To install the chart with the release name `my-release` at version 0.5.35:

```{.bash}
helm repo add rstudio https://helm.rstudio.com
helm upgrade --install my-release rstudio/rstudio-pm --version=0.5.34
helm upgrade --install my-release rstudio/rstudio-pm --version=0.5.35
```

To explore other chart versions, look at:
Expand Down Expand Up @@ -121,6 +121,14 @@ pod:
secretKeyRef:
name: rstudio-pm-database
key: password

# Temporarily work around bug in Package Manager 2024.08.2 where Postgres.UsageDataPassword
# does not default to Postgres.Password. This will be fixed in the next release of Package Manager.
- name: PACKAGEMANAGER_POSTGRES_USAGEDATAPASSWORD
valueFrom:
secretKeyRef:
name: rstudio-pm-database
key: password
```

Alternatively, database passwords may be set during `helm install` with the following argument:
Expand Down
8 changes: 8 additions & 0 deletions charts/rstudio-pm/README.md.gotmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,14 @@ pod:
secretKeyRef:
name: {{ .Name }}-database
key: password

# Temporarily work around bug in Package Manager 2024.08.2 where Postgres.UsageDataPassword
# does not default to Postgres.Password. This will be fixed in the next release of Package Manager.
- name: PACKAGEMANAGER_POSTGRES_USAGEDATAPASSWORD
valueFrom:
secretKeyRef:
name: {{ .Name }}-database
key: password
```

Alternatively, database passwords may be set during `helm install` with the following argument:
Expand Down