add and allow leading slash of ntrip source request #68
Conversation
allow header `Source-Agent:` or `User-Agent:` .
current ntrip caster does remove the leading slash of mount point in ntrip source client, and rtklib's ntrip source request does not contain leading slash in mount point name too. however, in ntrip spec, the example source request contain leading slash. although i am not sure whether request without slash is legal, i remove the leading slash of source request to compatible with other ntrip client software. moreover, i also add leading slash to source request.
GHolk
changed the title
|
this pr also allow source request not to use if you do not like it, just cherry-pick the commit ff3c3af only. |
|
FYI, RTKLIB connects to NTRIP Casters (as an NTRIP Server) using NTRIP Version 1 (Rev1) and the keyword "SOURCE" (which was changed to POST and User-Agent when used in Rev2). And in Rev 1, only the term Source Agent should be used with that keyword. Only a Rev1 NTRIP Client device, requesting from an NTRIP Caster (any rev), would use User-Agent (along with GET) in the headers. It should not use other keywords for the agent, but (as per HTTP) other header lines can be present. The forward slash before the mountPt name can be present or absent, there are many client deployments doing both ways, and this remains a point of debate within the NTRIP group of RTCM SC104. |
to fix issue #66, this pull request will add leading slash to source connection and allow connection contain slash. the old ntrip client can still connect to new server without add leading slash, but old ntrip caster can not deal with connection with leading slash.