Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An update_sla() function #284

Open
wants to merge 4 commits into
base: devel
Choose a base branch
from
Open

Conversation

kambleakash0
Copy link

Description

Wrote an update_sla() function based on the issue #250
Since CDM versions after 5.1 all have put the patch call for modifying SLA details in the V3, I have used the same call for those versions and versions for prior to 5.2 I have used the V1 put call to modify SLA parameters.

Related Issue

create update_sla() function to allow changing settings of an existing SLA #250

Motivation and Context

Provides a handy function call to users in case they want to modify an already created SLA.

How Has This Been Tested?

Tried to manually test it on a Rubrik cluster with CDM version 8.0.1-21908 but facing some issue.
Maybe due to V3 not being one of the valid API versions but facing the same issue even after I added 'v3' to the 'valid_api_versions' list inside '_api_validation()' from 'rubrik_cdm.py.Connect' class:
valid_api_versions = ['v1', 'v2', 'internal', 'v3']

Screenshot of the issue faced:

Screenshot 2022-09-09 214054

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

Go over all the following points, and put an x in all the boxes that apply. If you're unsure about any of these, don't hesitate to ask. We're here to help!

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTION document.
  • I have updated the CHANGELOG file accordingly for the version that this merge modifies.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@kambleakash0 kambleakash0 requested a review from a team as a code owner September 9, 2022 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants