Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Wrote an update_sla() function based on the issue #250
Since CDM versions after 5.1 all have put the
patch
call for modifying SLA details in the V3, I have used the same call for those versions and versions for prior to 5.2 I have used the V1put
call to modify SLA parameters.Related Issue
create update_sla() function to allow changing settings of an existing SLA #250
Motivation and Context
Provides a handy function call to users in case they want to modify an already created SLA.
How Has This Been Tested?
Tried to manually test it on a Rubrik cluster with CDM version 8.0.1-21908 but facing some issue.
Maybe due to V3 not being one of the valid API versions but facing the same issue even after I added 'v3' to the 'valid_api_versions' list inside '_api_validation()' from 'rubrik_cdm.py.Connect' class:
valid_api_versions = ['v1', 'v2', 'internal', 'v3']
Screenshot of the issue faced:
Types of changes
What types of changes does your code introduce? Put an
x
in all the boxes that apply:Checklist:
Go over all the following points, and put an
x
in all the boxes that apply. If you're unsure about any of these, don't hesitate to ask. We're here to help!