Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
Values in CLDR can have an
alt
attribute. While we figure out how we want to export them, we should ignore them so they don't accidentally get output.Ref #125.
What approach did you choose and why?
ruby-cldr
had aalt?
method that was being used in a few places to ignore these values, but it wasn't being consistently.I moved the filtering into
DataFile
, so the rest of the code doesn't even get a chance to see these values, so they can't possibly forget to remove them (thereby leaking them).What should reviewers focus on?
🤷
The impact of these changes
alt
values are hidden and not exported.Testing
...
Checklist