Add support for aliases in Gregorian eras #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
movermeyer
commented
Jun 30, 2022
| @@ -83,14 +83,18 @@ def periods | |||
|
|
|||
| def eras | |||
| if calendar | |||
| base_path = calendar.path.gsub("/ldml/", "") + "/eras" | |||
| base_path = calendar.path.sub(%r{^/ldml/}, "") + "/eras" | |||
There was a problem hiding this comment.
Tightened up the regex and made it non-global.
dpad46
approved these changes
Jul 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
Part of #78. Adding support for aliases within the
eraselements.What approach did you choose and why?
Added specific handling for
aliasnodes at that specific path.Then added the path to
validate_aliases_only_in_expected_pathsso that the list remaining alias locations gets smaller.What should reviewers focus on?
I didn't add support for aliases at
/ldml/dates/calendars/calendar/eras, but they are only present in non-Gregorian calendars, and we don't yet export those.(I wonder if there's a nice way to change
validate_aliases_only_in_expected_pathsto also check this assertion 🤔)The impact of these changes
Three less alias locations to handle.
Testing
...
Checklist