Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress -Wundef warnings on arm64 macOS and Windows #134

Merged
merged 1 commit into from
Sep 11, 2023

Conversation

nobu
Copy link
Member

@nobu nobu commented Sep 10, 2023

In file included from ../../../../ext/fiddle/fiddle.h:46:
/opt/local/include/ffi.h:477:5: warning: 'FFI_GO_CLOSURES' is not defined, evaluates to 0 [-Wundef]
    ^

c.f. libffi/libffi#796

```
In file included from ../../../../ext/fiddle/fiddle.h:46:
/opt/local/include/ffi.h:477:5: warning: 'FFI_GO_CLOSURES' is not defined, evaluates to 0 [-Wundef]
    ^
```

c.f. libffi/libffi#796
@nobu nobu requested a review from kou September 10, 2023 07:44
Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kou kou merged commit d4feb57 into ruby:master Sep 11, 2023
41 checks passed
@nobu nobu deleted the undef-warnings branch September 12, 2023 05:57
nobu added a commit to nobu/ruby that referenced this pull request Sep 17, 2023
(ruby/fiddle#134)

```
In file included from ../../../../ext/fiddle/fiddle.h:46:
/opt/local/include/ffi.h:477:5: warning: 'FFI_GO_CLOSURES' is not defined, evaluates to 0 [-Wundef]
    ^
```

c.f. libffi/libffi#796

ruby/fiddle@d4feb57098
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants