♻️ Switch IMAP tests to use FakeServer::TestHelper

ruby · Aug 21, 2023 · d1c5236 · d1c5236
1 parent a8e354e
commit d1c5236
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 23 deletions.
diff --git a/test/net/imap/fake_server/test_helper.rb b/test/net/imap/fake_server/test_helper.rb
@@ -15,6 +15,7 @@ def with_fake_server(select: nil, timeout: 5, **opts)
         if select
           client.select(select)
           server.commands.pop
+          assert server.state.selected?
         end
         yield server, client
       ensure

diff --git a/test/net/imap/test_imap.rb b/test/net/imap/test_imap.rb
@@ -9,6 +9,8 @@ class IMAPTest < Test::Unit::TestCase
   SERVER_KEY = File.expand_path("../fixtures/server.key", __dir__)
   SERVER_CERT = File.expand_path("../fixtures/server.crt", __dir__)
 
+  include Net::IMAP::FakeServer::TestHelper
+
   def setup
     @do_not_reverse_lookup = Socket.do_not_reverse_lookup
     Socket.do_not_reverse_lookup = true
@@ -1031,29 +1033,6 @@ def test_unselect
 
   private
 
-  def with_fake_server(select: nil, timeout: 5, **opts)
-    Timeout.timeout(timeout) do
-      server = Net::IMAP::FakeServer.new(timeout: timeout, **opts)
-      @threads << Thread.new do server.run end
-      tls = opts[:implicit_tls]
-      tls = {ca_file: server.config.tls[:ca_file]} if tls == true
-      client = Net::IMAP.new("localhost", port: server.port, ssl: tls)
-      begin
-        if select
-          client.select(select)
-          server.commands.pop
-          assert server.state.selected?
-        end
-        yield server, client
-      ensure
-        client.logout rescue pp $!
-        client.disconnect if !client.disconnected?
-      end
-    ensure
-      server&.shutdown
-    end
-  end
-
   def imaps_test(timeout: 10)
     Timeout.timeout(timeout) do
       server = create_tcp_server