Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indentation fixup #1209

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Indentation fixup #1209

wants to merge 4 commits into from

Conversation

herwinw
Copy link
Member

@herwinw herwinw commented Nov 3, 2024

This change consists of four commits:

  1. Fix some issues where we used 1 or 3 spaces instead of 2
  2. Fix some missing indentation blocks for guards like quarantine!
  3. Enable the Layout/IndentationWidth rubocop check
  4. Fix another offense of this Rubocop check in the IPAddr specs by adding a bunch of extra indentation

The few remaining offenses look like bugs in Rubocop, or I just don't understand what they're trying to say.

I ordered them by confidence/relevance, so if there is disagreement on any of the commits, we should probably omit the commits after that one as well.

The few remaining exceptions are either stylistic choices or errors in
Rubocop.
This resolves a Rubocop offense in Layout/IndentationWidth
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant