Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed components hierarchy #20

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixed components hierarchy #20

wants to merge 1 commit into from

Conversation

AntonioArts
Copy link

No description provided.

@@ -49,7 +49,7 @@ class App extends Component {
}


export default connect(state => ({
export default withRouter(connect(state => ({

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you explain for what do you use extra withRouter method here?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

withRouter adds history props to a wrapped component.
I fixed the root of the problem. Thanks for review

@AntonioArts AntonioArts changed the title Added withRouter wrapper for app component Fixed components hierarchy Feb 6, 2019
Copy link

@ianeinser ianeinser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,

are you sure that the history in App.js is a props not an imported parameter such as that imported through
import { history } from '../history';

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants