Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: release flow #108

Merged
merged 1 commit into from
Mar 14, 2024
Merged

fix: release flow #108

merged 1 commit into from
Mar 14, 2024

Conversation

sanpj2292
Copy link
Contributor

@sanpj2292 sanpj2292 commented Mar 12, 2024

Description of the change

We are adopting a single branch approach to release shopify-tracker to production

  • main will be that single branch
  • When a feature branch(development branch) is merged to main
  • It would first raise a release PR
  • Until this release PR is merged, all the commits getting merged to main will be added into release PR
  • Once release PR is merged
    • Github releases & tags are updated
    • The release-please branch(you can see this branch in release PR) is deleted
    • Notify the release to Slack

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Resolves INT-1568

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

Signed-off-by: Sai Sankeerth <sanpj2292@github.com>
@sanpj2292 sanpj2292 self-assigned this Mar 12, 2024
Copy link

sonarcloud bot commented Mar 12, 2024

@sanpj2292 sanpj2292 requested a review from utsabc March 12, 2024 13:30
@sanpj2292 sanpj2292 merged commit 5345f85 into develop Mar 14, 2024
7 checks passed
@sanpj2292 sanpj2292 deleted the fix.release branch March 14, 2024 13:58
@github-actions github-actions bot mentioned this pull request Mar 18, 2024
sanpj2292 added a commit that referenced this pull request Mar 20, 2024
sanpj2292 added a commit that referenced this pull request Mar 20, 2024
@github-actions github-actions bot mentioned this pull request Mar 20, 2024
sanpj2292 added a commit that referenced this pull request Mar 20, 2024
Revert "fix: release flow (#108)" (#120)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants