Skip to content

Commit

Permalink
Update cran-comments
Browse files Browse the repository at this point in the history
  • Loading branch information
rudeboybert committed Aug 4, 2020
1 parent 2dda24c commit f686414
Showing 1 changed file with 18 additions and 14 deletions.
32 changes: 18 additions & 14 deletions cran-comments.md
Original file line number Diff line number Diff line change
@@ -1,16 +1,27 @@
## Resubmission

This is a resubmission. In this version I have:

* Fully addressed the warnings in
https://cran.r-project.org/web/checks/check_results_fivethirtyeight.html
* In particular, the vignettes no longer dynamically read data off the web per
CRAN policy on internet access. All relevant data are now hardcoded into the
package.

Apologies for the oversight. Despite my best efforts at trying multiple test
environments, this breach of CRAN policy eluded me.

## Test environments

* local macOS install, R 4.0.1
* ubuntu 16.04.6 on travis-ci (release, devel, oldrel)
* win-builder (release, devel, oldrel)
* GitHub Actions
+ ubuntu-16.04: release
+ windows: release
+ macOS: release
* Rhub via devtools::check_rhub(env_vars=c(R_COMPILE_AND_INSTALL_PACKAGES = "always"))
+ Windows Server 2008 R2 SP1, R-devel, 32/64 bit
+ Ubuntu Linux 16.04 LTS, R-release, GCC

+ Fedora Linux, R-devel, clang, gfortran

## R CMD check results

Expand All @@ -20,18 +31,11 @@ am submitting before the 2020-08-05 deadline.

NOTES:

* Rhub (release, devel) returned 4 NOTES that the following URL's were
possibly invalid, however upon testing them individually, they all worked fine:
+ https://blog.gdeltproject.org/gdelt-2-0-television-api-debuts/
+ https://digital.library.unt.edu/ark:/67531/metadc815038/m2/1/high_res_d/98-19_2006Jun08.pdf
+ https://genius.com/
+ https://www.nps.gov/history/archeology/sites/antiquities/MonumentsList.htm
* win-builder (release, devel, oldrel) returned 3 NOTES because
'fivethirtyeightdata' is not a CRAN package, but rather a drat package
https://fivethirtyeightdata.github.io/drat:
* Because 'fivethirtyeightdata' is not a CRAN package but rather a drat package
https://fivethirtyeightdata.github.io/drat, we get:
+ Suggests or Enhances not in mainstream repositories: fivethirtyeightdata
+ Package suggested but not available for checking: 'fivethirtyeightdata'
+ Package unavailable to check Rd xrefs: 'fivethirtyeightdata'


* Found 571 marked UTF-8 strings
* installed package size is 5.1Mb

0 comments on commit f686414

Please sign in to comment.