Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add options to show RMSE and SSE #294

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

vibhoothi
Copy link
Contributor

MSE and RMSE are the classic metrics used for analysis, while modern
objective metrics outperform MSE and RMSE, for fast computation these
will be useful.

Ideally, if we want could make this optional, comments and suggestions welcome :)

@vibhoothi vibhoothi requested review from lu-zero and shssoichiro and removed request for lu-zero October 3, 2021 01:04
Copy link
Member

@lu-zero lu-zero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is a bit ugly that mse and rmse are computed again and again would be better to do that once and report the 3 values.

MSE and RMSE are the classic metrics used for analysis, while modern
objective metrics outperform MSE and RMSE, for fast computation these
will be useful.

This may not be the best way to get the results. Ideally, we need to
figure a way to do partial caching of results of PsnrResults and then
use those values for MSE and RMSE.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants