Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick fix for ffmpeg-the-third dependency issue #20

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

Woonters
Copy link

@Woonters Woonters commented Dec 15, 2024

By switching the dependency to point at the git-repo we can use the latest version of the package (which isn't 7 months behind) fixing a compile bug. This only requires 1 edit in the actual code which switches to getting a mutable version of the parameters
this closes #19

@Woonters
Copy link
Author

Alternatively if you want to avoid pointing at the git-repo for stability issues. Enable the feature "non-exhaustive-enums" in the features for "ffmpeg-the-third" implemented in this branch on my fork https://github.com/Woonters/grav1synth_versioning_fix/tree/compile_error

@shssoichiro
Copy link
Collaborator

Rather than point to the git repo, I went ahead and published a new version (3.0.0+ffmpeg-7.1.0) for ffmpeg-the-third. Could you try pointing this repo to the newly published version? Thanks.

@Woonters
Copy link
Author

I've done that, I will add that I had a short convo with the ffmpeg the third dev who said the main repo will be updated at some point they are just waiting on finalizing some major breaking changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Building Causes non-exhaustive pattern error
2 participants