Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix clippy warnings #1702

Merged
merged 18 commits into from
Oct 21, 2023
Merged

Fix clippy warnings #1702

merged 18 commits into from
Oct 21, 2023

Conversation

Geal
Copy link
Collaborator

@Geal Geal commented Oct 21, 2023

No description provided.

thatmarkenglishguy and others added 17 commits July 27, 2023 15:01
@thatmarkenglishguy
Unnecessary clone of i. Just use input.
5f04cfc
@thatmarkenglishguy
Unnecessary return statement removed.
d8aa8a6
@thatmarkenglishguy
Removed unnecessary clone calls for error kind parameter.
4652b4a 
Replaced auto-deref with explicit deref().
Simplified boolean logic.
Used empty Ranges instead of backwards Ranges.
@thatmarkenglishguy
clippy Ignore .idea/ folder.
dadc9c4
@thatmarkenglishguy
clippy cargo fmt.
8407470
@thatmarkenglishguy
Merge remote-tracking branch 'origin/main' into clippy
30a9d1b
@thatmarkenglishguy
Merge branch 'main' into clippy
bd477b9
@thatmarkenglishguy
clippy Avoid suspicious_double_ref_op.
8b738ea
@thatmarkenglishguy
clippy Remove empty range error.
ead9cc7
@thatmarkenglishguy
clippy Avoid single_match.
165194e
@thatmarkenglishguy
clippy Avoid needless_lifetimes.
4a51e44
@thatmarkenglishguy
clippy Avoid map_flatten.
a5efba0
@thatmarkenglishguy
clippy Avoid extra_unused_lifetimes
7466b7b
@thatmarkenglishguy
clippy Avoid more needless_lifetimes.
c6dfb2c
@thatmarkenglishguy
clippy Avoid redundant_slicing.
5cb8623
@Geal
Merge branch 'main' into clippy
1fe2f16
@Geal
fix nostd imports
95435e8
@Geal Geal mentioned this pull request Oct 21, 2023
Closed
@coveralls
Copy link

Pull Request Test Coverage Report for Build 6597381359

  • 14 of 19 (73.68%) changed or added relevant lines in 3 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.004%) to 61.975%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/traits.rs 7 12 58.33%
Files with Coverage Reduction New Missed Lines %
src/traits.rs 2 60.19%
Totals Coverage Status
Change from base Build 6597274691: 0.004%
Covered Lines: 1814
Relevant Lines: 2927
💛 - Coveralls

@Geal Geal merged commit 8c77435 into main Oct 21, 2023
28 checks passed
@Geal Geal deleted the thatmarkenglishguy/clippy branch October 21, 2023 12:41
@Geal
Copy link
Collaborator Author

Geal commented Oct 21, 2023

and done! thanks @thatmarkenglishguy !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Geal @coveralls @thatmarkenglishguy