Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement alt for dynamic arrays #1754

Merged
merged 1 commit into from
May 5, 2024
Merged

implement alt for dynamic arrays #1754

merged 1 commit into from
May 5, 2024

Conversation

Geal
Copy link
Collaborator

@Geal Geal commented May 5, 2024

Fix #1720

Copy link

codecov bot commented May 5, 2024

Codecov Report

Attention: Patch coverage is 61.53846% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 60.57%. Comparing base (82b09f0) to head (8ee8e8c).
Report is 3 commits behind head on main.

Files Patch % Lines
src/branch/mod.rs 61.53% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1754      +/-   ##
==========================================
- Coverage   62.01%   60.57%   -1.45%     
==========================================
  Files          24       24              
  Lines        2917     3282     +365     
==========================================
+ Hits         1809     1988     +179     
- Misses       1108     1294     +186     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented May 5, 2024

CodSpeed Performance Report

Merging #1754 will not alter performance

Comparing alt-dynamic-array (8ee8e8c) with main (cea6595)

Summary

✅ 24 untouched benchmarks

@Geal Geal merged commit 56b6e54 into main May 5, 2024
30 of 32 checks passed
@Geal Geal deleted the alt-dynamic-array branch May 5, 2024 16:14
epage added a commit to epage/winnow that referenced this pull request May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ergonomics of alt() taking tuple versus slice
1 participant