Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move nom into nom_core workspace and re-export #1787

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Ben-PH
Copy link

@Ben-PH Ben-PH commented Nov 13, 2024

This allows for the re-export of not only nom-core, thus making this a no-change to the api, it also allows for reexport of other community extensions, such as nom-supreme

I hope to follow up on this PR by

  • re-exporting nom-supreme behind a feature flag
  • re-exporting nom-locate behind a feature flag
  • moving some of the less "core" elements of nom into a re-exported workspace, putting them behind (default) feature flags.

The goal is to be able to integrate the nom ecosystem so that, instead of having to run

cargo add nom
cargo add nom-supreme
cargo add nom-locate

you can:

cargo add nom -F supreme locate

extra bit of fun:

to keep with the theme of this crate, we could also start adding "menu items". "extra toppings" (e.g. more verbose debug tracing). "amuse bouche" (e.g. exercise examples: have test cases and unimplemented parsers and implement them locally).

This allows for the re-export of not only nom-core, thus making
this a no-change to the api, it also allows for reexport of other community extensions, such as num-supreme
@Ben-PH Ben-PH requested a review from Geal as a code owner November 13, 2024 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant