Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused generic #193

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

tcharding
Copy link
Member

@tcharding tcharding commented Jul 31, 2024

Turns out clippy does not warn for unused generics.

Post merge edit for when we write changlog: API breaking change.

Fix: #191

@tcharding tcharding marked this pull request as draft July 31, 2024 19:41
Copy link
Member

@clarkmoody clarkmoody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK d0905b0

@tcharding
Copy link
Member Author

Force push is rebase only, will still need another one once #192 merges.

Turns out `clippy` does not warn for unused generics.

Fix: rust-bitcoin#191
@tcharding
Copy link
Member Author

Rebase only, no code changes.

@tcharding tcharding marked this pull request as ready for review August 6, 2024 22:28
Copy link
Member

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 7bdabff successfully ran local tests; note that this is technically a breaking change

@apoelstra apoelstra merged commit 7e03432 into rust-bitcoin:master Aug 6, 2024
12 checks passed
@apoelstra apoelstra deleted the 07-31-rm-unused-generic branch August 6, 2024 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CheckedHrpstring::fe32_iter has an unused generic
3 participants