Turn off nix's default features #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As far as I can tell from a quick search, this crate only uses a small subset of nix's functionality. No need to build all of it.
|
Semi-related to #122, as ideally, the dep could be entirely optional |
|
Awesome thanks! @smalis-msft may I ask you to make the nix dependency optional? It should be just a |
|
Note that unless you want to release a breaking change, you'll want to add a new |
cecton
changed the title
|
@cecton Any chance you could publish a release to crates.io with these changes? |
|
Hello! Yes sorry I completely forgot |
|
Released 1.0.2 |
|
All good, thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As far as I can tell from a quick search, this crate only uses a small subset of nix's functionality. No need to build all of it.