riscv: register: exports macros for custom CSRs
#203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmsyn
force-pushed
the
register/export-macros
branch
from
4aa288e to
1564199
Compare
rmsyn
commented
May 1, 2024
| @@ -1,3 +1,9 @@ | |||
| /// `RV64`: Convenience macro to wrap the `csrrs` assembly instruction for reading a CSR register. | |||
| /// | |||
| /// This macro should generally not be called directly. | |||
There was a problem hiding this comment.
Not sure if this is actually correct, as some of the existing register definitions directly call this macro.
Open to wording suggestions about correct usage here, and other similar locations.
rmsyn
commented
May 1, 2024
Exports macros from the `riscv::register::macros` module for external users. This allows external users to define custom CSR accessor functions. This is useful for platforms and SoCs with custom CSR registers not defined in the `riscv` crate. Resolves: rust-embedded#187
rmsyn
force-pushed
the
register/export-macros
branch
from
1564199 to
d72d7a3
Compare
taiki-e
reviewed
May 5, 2024
| @@ -1,3 +1,9 @@ | |||
| /// `RV64`: Convenience macro to wrap the `csrrs` assembly instruction for reading a CSR register. | |||
There was a problem hiding this comment.
This macro is for both RV32 and RV64. (Other non-*_rv32 macros are the same.)
For example:
riscv/riscv/src/register/mstatus.rs
Lines 274 to 277 in a9d3e33
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exports macros from the
riscv::register::macrosmodule for external users.This allows external users to define custom CSR accessor functions.
This is useful for platforms and SoCs with custom CSR registers not defined in the
riscvcrate.Resolves: #187