Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

riscv: use CSR macros for mcounteren #234

Merged

Conversation

rmsyn
Copy link
Contributor

@rmsyn rmsyn commented Oct 26, 2024

Uses CSR helper macros to define the mcounteren register.

Related: #229

@rmsyn rmsyn added this to the riscv 0.13.0 milestone Oct 26, 2024
@rmsyn rmsyn requested a review from a team as a code owner October 26, 2024 05:40
romancardenas
romancardenas previously approved these changes Oct 27, 2024
Copy link
Contributor

@romancardenas romancardenas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

rmsyn added 6 commits November 2, 2024 00:52
Uses CSR helper macros to define the `mcounteren` register.
Uses the CSR test helper macro for `mcounteren` register bit fields.
Extends the CSR test helper macro to handle range bit fields.
Uses the CSR test helper macro for `mcounteren` range fields.
Adds a CSR test helper macro branch for invalid range field values.
Uses the CSR test helper macro for invalid `mcounteren` range field
values.
@rmsyn
Copy link
Contributor Author

rmsyn commented Nov 2, 2024

LGTM

I added some extensions to the CSR test helper macro, and applied them to the unit tests for mcounteren.

Let me know what you think.

Copy link
Contributor

@romancardenas romancardenas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@romancardenas romancardenas added this pull request to the merge queue Nov 4, 2024
Merged via the queue into rust-embedded:master with commit 29dd75d Nov 4, 2024
101 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants