Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify register macros #250

Merged
merged 1 commit into from
Dec 19, 2024
Merged

Simplify register macros #250

merged 1 commit into from
Dec 19, 2024

Conversation

romancardenas
Copy link
Contributor

I added a cfg field and some recursive macro calls to reduce duplicates in register macros.

@romancardenas romancardenas requested a review from a team as a code owner December 18, 2024 12:53
rmsyn
rmsyn approved these changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@rmsyn rmsyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM, this is a good cleanup!

@romancardenas romancardenas added this pull request to the merge queue Dec 19, 2024
Merged via the queue into master with commit fe6da17 Dec 19, 2024
119 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmsyn rmsyn rmsyn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@romancardenas @rmsyn