Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Exception element to RISC-V builder #270

Merged
merged 2 commits into from
Aug 20, 2024

Conversation

romancardenas
Copy link
Contributor

As part of my work in this PR, I noticed that I forgot a mechanism to define custom exception sources. This PR should fix this.

@romancardenas romancardenas requested a review from a team as a code owner August 20, 2024 12:49
@burrbull
Copy link
Member

Please, avoid merging master branch. Use rebase instead.

@burrbull
Copy link
Member

Is Exception structure same as Interrupt?
We shoud reuse it instead of creating a copy.

@romancardenas
Copy link
Contributor Author

(Sorry, I used the sync button in GitHub)

I used copies so the tag ID is exception instead of interrupt. In RISC-V literature, it is common to see a clear separation between exceptions (synchronous events associated with an instruction) and interrupts (external event that occurs asynchronously to the current running thread). In any case, I don't have a strong opinion on this, so if you prefer, I can use interrupt elements instead of the current exception copy.

@burrbull burrbull added this pull request to the merge queue Aug 20, 2024
Merged via the queue into rust-embedded:master with commit 5989a86 Aug 20, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants