game-activity: Remove Deref implementations for Key/MotionEvent types #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rib
force-pushed
the
rib/pr/game-activity-no-input-deref
branch
from
3a5b1e2
to
c22a545
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was a mistake to expose a public Deref implementation for the
KeyEventandMotionEventtypes for the GameActivity backend.It was very surprising to see these Winit changes temporarily rely on this: rust-windowing/winit@9184309#diff-9169a22d6397a250be741006cd857b8a575f804c74cc07e3a4fb8f3341606d9b
Fixes: #91