Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert 'Bump MSRV to 1.68' #104

Merged
merged 1 commit into from
Aug 7, 2023
Merged

Revert 'Bump MSRV to 1.68' #104

merged 1 commit into from
Aug 7, 2023

Commits on Aug 4, 2023

  1. Revert 'Bump MSRV to 1.68'

    This effectively reverts 66cfc68
    and adds some comments explaining that we're currently blocked by
    Winit's MSRV policy + CI from being able to increase our
    rust-version.
    
    This is a frustrating conflict that I hope can be addressed by
    updating Winit's CI system to allow different platforms to require
    more recent versions of Rust (which notably isn't in conflict with
    setting a conservative rust-version in Winit for supporting Debian
    on Linux)
    
    This re-instates building android-activity with cargo-ndk 2 because
    building on Android with 1.64 requires a linker workaround that's
    not implemented in newer version of cargo-ndk.
    
    This also reinstates the clippy false-negative warning suppression
    for unsafe blocks. Again it's frustrating that we can't have good
    things because of how Winit wants to support Debian which shouldn't
    be relevant for Android development.
    
    Here is an upstream issue to discuss a potential solution for this:
    rust-windowing/winit#3000
    rib committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    1abb02c View commit details
    Browse the repository at this point in the history