Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable CI on all branches #124

Merged
merged 1 commit into from
Sep 26, 2023
Merged

Conversation

fornwall
Copy link
Collaborator

@fornwall fornwall commented Sep 26, 2023

Enabling CI on all branches makes it smoother for external contributors, who can check CI status before creating a PR and awaiting approval of a workflow run.

For pull requests the behaviour in this repository is the same - a workflow run on a PR still requires approval. But for forks, this helps out with faster CI feedback.

@rib
Copy link
Collaborator

rib commented Sep 26, 2023

Thanks, yeah the other thing is that the default is that actions have to be approved for 'first time contributors'.

I've also changed that to approve to 'first time contributors who are new to github'

@rib rib merged commit 733fabf into rust-mobile:main Sep 26, 2023
3 checks passed
@fornwall fornwall deleted the enable-ci-on-all-branches branch September 26, 2023 19:40
@@ -2,7 +2,7 @@ name: ci

on:
push:
branches: [main]
branches: '*'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
branches: '*'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants