Commits on Nov 20, 2023

1. Generalize log-forwarding setup and stop thread on IO errors …

   When `read_line()` starts returning `Err` the current `if let Ok`
   condition ignores those, likely causing the `loop` to spin indefinitely
   while this function keeps returning errors.
   
   Note that we don't currently store the join handle for this thread
   anywhere, so won't see the error surface either (just like how the join
   handle for the main thread is never checked).  Perhaps we should call
   `log::error!()` to make the user aware that their IO logging has
   mysteriously terminated.

   

   MarijnS95 committed Nov 20, 2023
   Configuration menu

   • View commit details
   • Copy full SHA for af34189
   • Browse repository at this point

   Copy the full SHA

   af34189 View commit details

   Browse the repository at this point in the history