Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set workspace.resolver = "2" and avoid cargo warning #135

Merged
merged 1 commit into from
Oct 16, 2023

Conversation

rib
Copy link
Collaborator

@rib rib commented Oct 16, 2023

Since we're using edition = "2021" in android-activity/Cargo.toml (which defaults to the v2 resolver) then cargo warns that this isn't consistent with the v1 resolver default for the top-level workspace.

@rib rib force-pushed the rib/pr/workspace-resolver-v2 branch from bb09f86 to acc1c44 Compare October 16, 2023 19:12
@rib rib force-pushed the rib/pr/doc-cloneable-app branch 2 times, most recently from 852b6f1 to d8c3a29 Compare October 16, 2023 19:32
@rib rib force-pushed the rib/pr/workspace-resolver-v2 branch from acc1c44 to 359dc8a Compare October 16, 2023 20:14
@rib rib changed the base branch from rib/pr/doc-cloneable-app to main October 16, 2023 20:14
@rib rib merged commit b590ec5 into main Oct 16, 2023
3 checks passed
@MarijnS95 MarijnS95 deleted the rib/pr/workspace-resolver-v2 branch October 16, 2023 21:49
@MarijnS95
Copy link
Member

Nice, yeah this warning started to show for a bunch of crates for me since Rust 1.70 or something close to that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants