project: misc CI improvements. #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #145 +/- ##
=========================================
Coverage ? 70.28%
=========================================
Files ? 7
Lines ? 1898
Branches ? 0
=========================================
Hits ? 1334
Misses ? 564
Partials ? 0 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
est31
requested changes
Aug 25, 2023
djc
reviewed
Aug 25, 2023
This will provide a more consistent experience. By relying on Dependabot (see follow-up commit) we can keep up to date with the upstream project without unexpected updates happening out from under us.
This commit updates the `on` configuration to run CI jobs for `merge_group` (to allow using the merge queue feature) and on a scheduled basis (to catch bitrot during periods of lower project activity).
This ensures `cargo clippy` is run consistently, and denies warnings.
This adds a CI workflow task that will measure code coverage and upload it to codecov.io. We don't configure this task to fail CI if there is an error, it is a best-effort process.
This commit updates the CI config to also deny warnings from `rustdoc`. One finding related to a malformed HTML tag is fixed to ensure CI passes with this new config.
cpu
changed the title
est31
approved these changes
Aug 28, 2023
djc
approved these changes
Aug 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recommend reviewing this branch commit-by-commit.
There are no functional changes to the code, just CI improvements.