Generic Seq2Seq Decoder preparation #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
curufinwe
requested changes
Apr 3, 2023
SimBe195
commented
Apr 17, 2023
| @@ -37,10 +39,11 @@ namespace Speech { | |||
| class ModelCombination : public Mc::Component, public Core::ReferenceCounted { | |||
| public: | |||
| typedef u32 Mode; | |||
| static const Mode complete; | |||
| static const Mode complete; // Includes lexicon, AM and LM but NOT label scorer; named 'complete' for legacy reasons. | |||
There was a problem hiding this comment.
While the name complete is a bit misleading now because it doesn't include the label scorer, changing it would mean a config-level change since the name 'complete' is also used in src/Speech/LatticeNodes.cc for a Core::Choice ModelCombinationNode::choiceMode. So a comment was added here and the name is left as-is for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a subset of changes from #45. These are all the smaller file changes that prepare the rest of the code base for the new module but omitting actual implementations of the new label scorers and search/alignment algorithms.
The code in this PR can be compiled successfully but the new classes are mostly empty and non-functional at this stage.