Skip to content

Commit

Permalink
ci: rename some jobs
Browse files Browse the repository at this point in the history
  • Loading branch information
ryboe committed Nov 9, 2024
1 parent 80d900d commit ffeda21
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 2 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ jobs:
version: latest

check:
name: go vet
name: go vet and staticcheck
runs-on: ubuntu-latest
steps:
- name: checkout repository
Expand All @@ -42,7 +42,7 @@ jobs:
version: latest

tests:
name: run unit tests with the race detector enabled
name: unit tests with race detector enabled
runs-on: ubuntu-latest
steps:
- name: checkout repository
Expand Down
3 changes: 3 additions & 0 deletions args_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -167,9 +167,11 @@ func TestExtractingArgsFromSourceText(t *testing.T) {
},
}

// We can test both exprToString() and argName() with the test cases above.
for _, tc := range testCases {
// test exprToString()
testName := fmt.Sprintf("exprToString(%T)", tc.arg)
// nolint: thelper
t.Run(testName, func(t *testing.T) {
if _, ok := tc.arg.(*ast.Ident); ok {
return
Expand All @@ -182,6 +184,7 @@ func TestExtractingArgsFromSourceText(t *testing.T) {

// test argName()
testName = fmt.Sprintf("argName(%T)", tc.arg)
// nolint: thelper
t.Run(testName, func(t *testing.T) {
if got := argName(tc.arg); got != tc.want {
t.Fatalf("\ngot: %s\nwant: %s", got, tc.want)
Expand Down

0 comments on commit ffeda21

Please sign in to comment.