Fix possible nil pointer deference

If err != nil, we'll still read response.Body, which is bad
rys · Jan 23, 2019 · f9870bd · f9870bd
1 parent 21d59f1
commit f9870bd
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/src/mbdns.go b/src/mbdns.go
@@ -68,14 +68,14 @@ func process() {
 
 			response, err := http.PostForm(mbURL, url.Values{"domain": {records[i].Domain}, "password": {records[i].Token}, "command": {command}})
 
-			body, _ := ioutil.ReadAll(response.Body)
-			response.Body.Close()
-
 			if err != nil {
 				log.Println(fmt.Sprintf(mbResponseError, records[i].Host, records[i].Domain, records[i].Record, records[i].TTL, err.Error()))
 				continue
 			}
 
+			body, _ := ioutil.ReadAll(response.Body)
+			response.Body.Close()
+
 			if response.StatusCode != 200 {
 				log.Println(fmt.Sprintf(mbResponseError, records[i].Host, records[i].Domain, records[i].Record, records[i].TTL, response.Status))