Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sdk): Add max transaction size check #122

Merged
merged 1 commit into from
Jul 10, 2024

Conversation

kevzzsk
Copy link
Collaborator

@kevzzsk kevzzsk commented Jul 10, 2024

What this PR does / why we need it:

  1. add tx size standardness check to enforce max 400,000 WU that is max tx that will be accepted by bitcoin core.
  2. make setDefaultAddress second param as optional to make it backward compatible

Which issue(s) does this PR fixes?:

Fixes #

Additional comments?:

Developer Checklist:

  • Read your code changes at least once
  • No console errors
  • Unit tests*
  • Added e2e tests*

@kevzzsk kevzzsk self-assigned this Jul 10, 2024
@kevzzsk kevzzsk merged commit ec85938 into sadoprotocol:main Jul 10, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants