SAK-49949 tasks Soft delete tasks for soft deleted sites #12945
Conversation
| @@ -21,11 +21,11 @@ | |||
| <bean id="org.sakaiproject.tasks.api.TaskService" | |||
| class="org.sakaiproject.tasks.impl.TaskServiceImpl" init-method="init"> | |||
|
|
|||
| <property name="transactionTemplate"> | |||
| <!--property name="transactionTemplate"> | |||
|
@ern SOFT_DELETED because they mimic site soft deletion. If the sites are restored, then the tasks are too. |
|
Yeah I understand that but I am not convinced it makes sense to mark the data as softly deleted if the site is softly deleted. Simply checking if the site is softly deleted (SAKAI_SITE.IS_SOFTLY_DELETED) should be enough to say don't load tasks from this site. |
|
Ok, fair enough. I can do that. |
|
@ern Updating to check all the sites when loading up the synoptic tasks would take potentially a lot of calls to the site service. I know they are cached, but still. |
| @@ -95,7 +98,10 @@ public void update(Observable o, Object arg) { | |||
| if (event.getEvent().equals(SiteService.SECURE_UPDATE_SITE_MEMBERSHIP)) { | |||
| try { | |||
| Set<String> siteUsers = siteService.getSite(event.getContext()).getUsers(); | |||
There was a problem hiding this comment.
I know this is out of scope for your PR, just an FYI for anyone following. event.getContext() is usually null here. also it can get called thousands of times in quick succession during SIS updates ;)
https://sakaiproject.atlassian.net/browse/SAK-49949