Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional onedir related fixes #149

Merged
merged 19 commits into from
Jul 27, 2023
Merged

Conversation

s0undt3ch
Copy link
Contributor

No description provided.

Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
…factories is being used

Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
@codecov
Copy link

codecov bot commented Jul 26, 2023

Codecov Report

Merging #149 (11a51c2) into master (55add98) will decrease coverage by 1.10%.
Report is 18 commits behind head on master.
The diff coverage is 67.63%.

❗ Current head 11a51c2 differs from pull request most recent head 0af3d21. Consider uploading reports for the commit 0af3d21 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #149      +/-   ##
==========================================
- Coverage   85.39%   84.29%   -1.10%     
==========================================
  Files          96       96              
  Lines        5605     5817     +212     
  Branches      621      629       +8     
==========================================
+ Hits         4786     4903     +117     
- Misses        625      730     +105     
+ Partials      194      184      -10     
Flag Coverage Δ
Linux 83.76% <66.27%> (-1.52%) ⬇️
Py35 ?
Py36 ?
Py37 ?
Py38 ?
Py39 ?
PyTest61 ?
PyTest62 ?
PyTest70 ?
PyTest71 ?
Salt3005rc2 ?
Windows 77.34% <73.29%> (?)
macOS 77.61% <64.60%> (?)
py3.10 83.90% <66.72%> (?)
py3.7 83.04% <65.59%> (?)
py3.8 83.90% <66.77%> (?)
py3.9 83.98% <67.23%> (?)
pytest-7.3.0 83.97% <67.02%> (?)
pytest-7.4.0 83.97% <67.02%> (?)
salt-3005.0 83.76% <66.27%> (?)
salt-3006.0 83.95% <66.87%> (?)
src 76.45% <63.39%> (-1.86%) ⬇️
tests 95.69% <92.69%> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/saltfactories/client.py 34.00% <0.00%> (-2.00%) ⬇️
src/saltfactories/plugins/markers.py 100.00% <ø> (ø)
tests/functional/test_cli.py 84.62% <0.00%> (ø)
...tories/daemons/container/test_container_factory.py 100.00% <ø> (ø)
...ntegration/factories/daemons/master/test_master.py 100.00% <ø> (ø)
...ries/daemons/minion/test_event_forwarder_engine.py 92.50% <ø> (ø)
...ntegration/factories/daemons/minion/test_minion.py 100.00% <ø> (ø)
...integration/factories/daemons/ssh/test_salt_ssh.py 100.00% <ø> (ø)
...ltfactories/utils/saltext/engines/pytest_engine.py 20.41% <13.94%> (-9.32%) ⬇️
...gration/factories/daemons/container/test_minion.py 91.53% <33.34%> (+2.64%) ⬆️
... and 64 more

... and 1 file with indirect coverage changes

@s0undt3ch s0undt3ch force-pushed the master branch 7 times, most recently from c278b6d to 11a51c2 Compare July 27, 2023 12:51
Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
Fixes saltstack#146

Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
@s0undt3ch s0undt3ch merged commit 34f1f71 into saltstack:master Jul 27, 2023
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant