Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several improvements towards rc25 #157

Merged
merged 4 commits into from
Jul 31, 2023
Merged

Conversation

s0undt3ch
Copy link
Contributor

No description provided.

…er modules

Fixes saltstack#156

Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
Fixes saltstack#155

Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
Fixes saltstack#154

Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
@codecov
Copy link

codecov bot commented Jul 29, 2023

Codecov Report

Merging #157 (5a69f8e) into master (2f1129d) will increase coverage by 0.67%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #157      +/-   ##
==========================================
+ Coverage   84.31%   84.97%   +0.67%     
==========================================
  Files          96       96              
  Lines        5816     5755      -61     
  Branches      629      615      -14     
==========================================
- Hits         4903     4890      -13     
+ Misses        729      692      -37     
+ Partials      184      173      -11     
Flag Coverage Δ
Linux 84.44% <88.89%> (+0.67%) ⬆️
Windows 77.84% <88.89%> (+0.51%) ⬆️
macOS 78.22% <88.89%> (+0.60%) ⬆️
py3.10 84.57% <94.45%> (+0.67%) ⬆️
py3.7 83.73% <88.24%> (+0.69%) ⬆️
py3.8 84.57% <91.67%> (+0.67%) ⬆️
py3.9 84.66% <94.45%> (+0.67%) ⬆️
pytest-7.3.0 84.64% <94.45%> (+0.67%) ⬆️
pytest-7.4.0 84.64% <94.45%> (+0.67%) ⬆️
salt-3005.0 84.44% <88.89%> (+0.67%) ⬆️
salt-3006.0 84.63% <94.45%> (+0.67%) ⬆️
src 76.93% <90.48%> (+0.46%) ⬆️
tests 96.63% <100.00%> (+0.95%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/saltfactories/plugins/__init__.py 85.72% <ø> (-5.19%) ⬇️
...ltfactories/utils/saltext/engines/pytest_engine.py 21.40% <ø> (+0.88%) ⬆️
src/saltfactories/utils/virtualenv.py 78.44% <ø> (+1.51%) ⬆️
...tional/factories/daemons/test_container_factory.py 100.00% <ø> (+4.88%) ⬆️
tests/functional/loader/test_loader.py 100.00% <ø> (+1.79%) ⬆️
tests/functional/test_cli.py 100.00% <ø> (+15.39%) ⬆️
...ntegration/factories/daemons/container/conftest.py 100.00% <ø> (+16.67%) ⬆️
...gration/factories/daemons/container/test_minion.py 96.43% <ø> (+4.91%) ⬆️
...ries/daemons/minion/test_event_forwarder_engine.py 97.37% <ø> (+4.87%) ⬆️
...ation/factories/daemons/proxy/test_proxy_minion.py 100.00% <ø> (+3.93%) ⬆️
... and 6 more

... and 1 file with indirect coverage changes

By either removing code not getting used anymore or marking sections of the code which are not expected to be covered.

Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
@s0undt3ch s0undt3ch merged commit 5db8c53 into saltstack:master Jul 31, 2023
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant