This repository has been archived by the owner on Feb 15, 2023. It is now read-only.
[WIP] [Do not merge] - fix import for livesql #422
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This 'fixes' the issue described in #364 for versions using livesql, but breaks CI (not sure why)
For some reason, my Go wants this passed in by value, not with a pointer, even though the vendor function here asks for a pointer:
The CI for this does not pass against Go 1.10: https://travis-ci.com/github/jrcichra/thunder/builds/188509884
But I am able to compile it fine against my fork: https://github.com/jrcichra/thunder which master has additional changes for pulling my fork version.
my program outside of this lib uses go.mod to compile, and includes:
...and go build succeeds with a 1.15.x compiler importing these sections in
main
of a dependent program: