Skip to content
This repository has been archived by the owner on Feb 15, 2023. It is now read-only.

[WIP] [Do not merge] - fix import for livesql #422

Closed
wants to merge 1 commit into from

Conversation

jrcichra
Copy link

@jrcichra jrcichra commented Oct 7, 2020

This 'fixes' the issue described in #364 for versions using livesql, but breaks CI (not sure why)

For some reason, my Go wants this passed in by value, not with a pointer, even though the vendor function here asks for a pointer:

vendor/github.com/siddontang/go-mysql/replication/binlogsyncer.go:

func NewBinlogSyncer(cfg *BinlogSyncerConfig) *BinlogSyncer {

The CI for this does not pass against Go 1.10: https://travis-ci.com/github/jrcichra/thunder/builds/188509884

But I am able to compile it fine against my fork: https://github.com/jrcichra/thunder which master has additional changes for pulling my fork version.

my program outside of this lib uses go.mod to compile, and includes:

github.com/jrcichra/thunder v0.5.1-0.20201007045717-c82d2fa57e8a

...and go build succeeds with a 1.15.x compiler importing these sections in main of a dependent program:

"github.com/jrcichra/thunder/graphql"
"github.com/jrcichra/thunder/graphql/graphiql"
"github.com/jrcichra/thunder/graphql/introspection"
"github.com/jrcichra/thunder/graphql/schemabuilder"
"github.com/jrcichra/thunder/livesql"
"github.com/jrcichra/thunder/reactive"

@jrcichra jrcichra changed the title fix import for livesql [WIP] [Do not merge] - fix import for livesql Oct 7, 2020
@jrcichra jrcichra closed this Feb 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant